Merge pull request #708 from corporateshark/master

Fixed #692: sphericalRand() is doing correct distribution on a sphere #708
ago%!(EXTRA string=8 years) · fa668e26b6
parent 1190ae0b0e 84e6d82051
commit fa668e26b6
1 changed files with 5 additions and 6 deletions
--- a/glm/gtc/random.inl
+++ b/glm/gtc/random.inl
@ -340,13 +340,12 @@ namespace detail
 	template<typename T>
 	GLM_FUNC_QUALIFIER vec<3, T, defaultp> sphericalRand(T Radius)
 	{
-		T z = linearRand(T(-1), T(1));
-		T a = linearRand(T(0), T(6.283185307179586476925286766559f));
+		T theta = linearRand(T(0), T(6.283185307179586476925286766559f));
+		T phi = std::acos(linearRand(T(-1.0f), T(1.0f)));

-		T r = sqrt(T(1) - z * z);
-
-		T x = r * std::cos(a);
-		T y = r * std::sin(a);
+		T x = std::sin(phi) * std::cos(theta);
+		T y = std::sin(phi) * std::sin(theta);
+		T z = std::cos(phi);

 		return vec<3, T, defaultp>(x, y, z) * Radius;
 	}