anulax
/
glm
1
0
Fork 0
Code Issues Pull Requests Packages project_board Releases Wiki Activity

Fixed error: comparing floating point with == or != is unsafe

Browse Source
master
Groove ago%!(EXTRA string=7 years)
parent 29f7e00e16
commit b2ba0c317d
1 changed files with 17 additions and 17 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 34
      test/core/core_type_vec3.cpp

34
test/core/core_type_vec3.cpp
Unescape View File

@ -498,9 +498,9 @@ int test_vec3_swizzle_partial()
# if GLM_SWIZZLE == GLM_SWIZZLE_OPERATOR # if GLM_SWIZZLE == GLM_SWIZZLE_OPERATOR
{ {
glm::ivec3 const A(1, 2, 3); glm::vec3 const A(1, 2, 3);
glm::ivec3 B(A.xy, 3); glm::vec3 B(A.xy, 3);
Error += A == B ? 0 : 1; Error += glm::all(glm::equal(A, B, glm::epsilon<float>())) ? 0 : 1;
} }
{ {
@ -561,13 +561,13 @@ static int test_swizzle()
glm::vec3 G(A.xy, A.z); glm::vec3 G(A.xy, A.z);
glm::vec3 H(A.xy(), A.z); glm::vec3 H(A.xy(), A.z);
Error += glm::all(glm::equal(A, B)) ? 0 : 1; Error += glm::all(glm::equal(A, B, glm::epsilon<float>())) ? 0 : 1;
Error += glm::all(glm::equal(A, C)) ? 0 : 1; Error += glm::all(glm::equal(A, C, glm::epsilon<float>())) ? 0 : 1;
Error += glm::all(glm::equal(A, D)) ? 0 : 1; Error += glm::all(glm::equal(A, D, glm::epsilon<float>())) ? 0 : 1;
Error += glm::all(glm::equal(A, E)) ? 0 : 1; Error += glm::all(glm::equal(A, E, glm::epsilon<float>())) ? 0 : 1;
Error += glm::all(glm::equal(A, F)) ? 0 : 1; Error += glm::all(glm::equal(A, F, glm::epsilon<float>())) ? 0 : 1;
Error += glm::all(glm::equal(A, G)) ? 0 : 1; Error += glm::all(glm::equal(A, G, glm::epsilon<float>())) ? 0 : 1;
Error += glm::all(glm::equal(A, H)) ? 0 : 1; Error += glm::all(glm::equal(A, H, glm::epsilon<float>())) ? 0 : 1;
} }
# endif//GLM_SWIZZLE == GLM_SWIZZLE_OPERATOR # endif//GLM_SWIZZLE == GLM_SWIZZLE_OPERATOR
@ -582,13 +582,13 @@ static int test_swizzle()
glm::vec3 G(A.xy(), A.z); glm::vec3 G(A.xy(), A.z);
glm::vec3 H(A.xy(), A.z); glm::vec3 H(A.xy(), A.z);
Error += glm::all(glm::equal(A, B)) ? 0 : 1; Error += glm::all(glm::equal(A, B, glm::epsilon<float>())) ? 0 : 1;
Error += glm::all(glm::equal(A, C)) ? 0 : 1; Error += glm::all(glm::equal(A, C, glm::epsilon<float>())) ? 0 : 1;
Error += glm::all(glm::equal(A, D)) ? 0 : 1; Error += glm::all(glm::equal(A, D, glm::epsilon<float>())) ? 0 : 1;
Error += glm::all(glm::equal(A, E)) ? 0 : 1; Error += glm::all(glm::equal(A, E, glm::epsilon<float>())) ? 0 : 1;
Error += glm::all(glm::equal(A, F)) ? 0 : 1; Error += glm::all(glm::equal(A, F, glm::epsilon<float>())) ? 0 : 1;
Error += glm::all(glm::equal(A, G)) ? 0 : 1; Error += glm::all(glm::equal(A, G, glm::epsilon<float>())) ? 0 : 1;
Error += glm::all(glm::equal(A, H)) ? 0 : 1; Error += glm::all(glm::equal(A, H, glm::epsilon<float>())) ? 0 : 1;
} }
# endif//GLM_SWIZZLE == GLM_SWIZZLE_OPERATOR || GLM_SWIZZLE == GLM_SWIZZLE_FUNCTION # endif//GLM_SWIZZLE == GLM_SWIZZLE_OPERATOR || GLM_SWIZZLE == GLM_SWIZZLE_FUNCTION

Write Preview
Loading…
Cancel
Save