Use switch statement instead of if-else-chain

Related to #1739

src/input.c

@@ -522,90 +522,102 @@ GLFWAPI void glfwSetInputMode(GLFWwindow* handle, int mode, int value)
 
     _GLFW_REQUIRE_INIT();
 
-    if (mode == GLFW_CURSOR)
+    switch (mode)
     {
-        if (value != GLFW_CURSOR_NORMAL &&
+        case GLFW_CURSOR:
-            value != GLFW_CURSOR_HIDDEN &&
-            value != GLFW_CURSOR_DISABLED)
         {
-            _glfwInputError(GLFW_INVALID_ENUM,
+            if (value != GLFW_CURSOR_NORMAL &&
-                            "Invalid cursor mode 0x%08X",
+                value != GLFW_CURSOR_HIDDEN &&
-                            value);
+                value != GLFW_CURSOR_DISABLED)
-            return;
+            {
-        }
+                _glfwInputError(GLFW_INVALID_ENUM,
+                                "Invalid cursor mode 0x%08X",
+                                value);
+                return;
+            }
 
-        if (window->cursorMode == value)
+            if (window->cursorMode == value)
-            return;
+                return;
 
-        window->cursorMode = value;
+            window->cursorMode = value;
 
-        _glfw.platform.getCursorPos(window,
+            _glfw.platform.getCursorPos(window,
-                                    &window->virtualCursorPosX,
+                                        &window->virtualCursorPosX,
-                                    &window->virtualCursorPosY);
+                                        &window->virtualCursorPosY);
-        _glfw.platform.setCursorMode(window, value);
+            _glfw.platform.setCursorMode(window, value);
-    }
-    else if (mode == GLFW_STICKY_KEYS)
-    {
-        value = value ? GLFW_TRUE : GLFW_FALSE;
-        if (window->stickyKeys == value)
             return;
+        }
 
-        if (!value)
+        case GLFW_STICKY_KEYS:
         {
-            int i;
+            value = value ? GLFW_TRUE : GLFW_FALSE;
+            if (window->stickyKeys == value)
+                return;
 
-            // Release all sticky keys
+            if (!value)
-            for (i = 0;  i <= GLFW_KEY_LAST;  i++)
             {
-                if (window->keys[i] == _GLFW_STICK)
+                int i;
-                    window->keys[i] = GLFW_RELEASE;
+
+                // Release all sticky keys
+                for (i = 0;  i <= GLFW_KEY_LAST;  i++)
+                {
+                    if (window->keys[i] == _GLFW_STICK)
+                        window->keys[i] = GLFW_RELEASE;
+                }
             }
-        }
 
-        window->stickyKeys = value;
+            window->stickyKeys = value;
-    }
-    else if (mode == GLFW_STICKY_MOUSE_BUTTONS)
-    {
-        value = value ? GLFW_TRUE : GLFW_FALSE;
-        if (window->stickyMouseButtons == value)
             return;
+        }
 
-        if (!value)
+        case GLFW_STICKY_MOUSE_BUTTONS:
         {
-            int i;
+            value = value ? GLFW_TRUE : GLFW_FALSE;
+            if (window->stickyMouseButtons == value)
+                return;
 
-            // Release all sticky mouse buttons
+            if (!value)
-            for (i = 0;  i <= GLFW_MOUSE_BUTTON_LAST;  i++)
             {
-                if (window->mouseButtons[i] == _GLFW_STICK)
+                int i;
-                    window->mouseButtons[i] = GLFW_RELEASE;
+
+                // Release all sticky mouse buttons
+                for (i = 0;  i <= GLFW_MOUSE_BUTTON_LAST;  i++)
+                {
+                    if (window->mouseButtons[i] == _GLFW_STICK)
+                        window->mouseButtons[i] = GLFW_RELEASE;
+                }
             }
+
+            window->stickyMouseButtons = value;
+            return;
         }
 
-        window->stickyMouseButtons = value;
+        case GLFW_LOCK_KEY_MODS:
-    }
-    else if (mode == GLFW_LOCK_KEY_MODS)
-    {
-        window->lockKeyMods = value ? GLFW_TRUE : GLFW_FALSE;
-    }
-    else if (mode == GLFW_RAW_MOUSE_MOTION)
-    {
-        if (!_glfw.platform.rawMouseMotionSupported())
         {
-            _glfwInputError(GLFW_PLATFORM_ERROR,
+            window->lockKeyMods = value ? GLFW_TRUE : GLFW_FALSE;
-                            "Raw mouse motion is not supported on this system");
             return;
         }
 
-        value = value ? GLFW_TRUE : GLFW_FALSE;
+        case GLFW_RAW_MOUSE_MOTION:
-        if (window->rawMouseMotion == value)
+        {
-            return;
+            if (!_glfw.platform.rawMouseMotionSupported())
+            {
+                _glfwInputError(GLFW_PLATFORM_ERROR,
+                                "Raw mouse motion is not supported on this system");
+                return;
+            }
+
+            value = value ? GLFW_TRUE : GLFW_FALSE;
+            if (window->rawMouseMotion == value)
+                return;
 
-        window->rawMouseMotion = value;
+            window->rawMouseMotion = value;
-        _glfw.platform.setRawMouseMotion(window, value);
+            _glfw.platform.setRawMouseMotion(window, value);
+            return;
+        }
     }
-    else
+
-        _glfwInputError(GLFW_INVALID_ENUM, "Invalid input mode 0x%08X", mode);
+    _glfwInputError(GLFW_INVALID_ENUM, "Invalid input mode 0x%08X", mode);
 }
 
 GLFWAPI int glfwRawMouseMotionSupported(void)

src/window.c

@@ -882,35 +882,41 @@ GLFWAPI void glfwSetWindowAttrib(GLFWwindow* handle, int attrib, int value)
 
     value = value ? GLFW_TRUE : GLFW_FALSE;
 
-    if (attrib == GLFW_AUTO_ICONIFY)
+    switch (attrib)
-        window->autoIconify = value;
-    else if (attrib == GLFW_RESIZABLE)
-    {
-        window->resizable = value;
-        if (!window->monitor)
-            _glfw.platform.setWindowResizable(window, value);
-    }
-    else if (attrib == GLFW_DECORATED)
-    {
-        window->decorated = value;
-        if (!window->monitor)
-            _glfw.platform.setWindowDecorated(window, value);
-    }
-    else if (attrib == GLFW_FLOATING)
-    {
-        window->floating = value;
-        if (!window->monitor)
-            _glfw.platform.setWindowFloating(window, value);
-    }
-    else if (attrib == GLFW_FOCUS_ON_SHOW)
-        window->focusOnShow = value;
-    else if (attrib == GLFW_MOUSE_PASSTHROUGH)
     {
-        window->mousePassthrough = value;
+        case GLFW_AUTO_ICONIFY:
-        _glfw.platform.setWindowMousePassthrough(window, value);
+            window->autoIconify = value;
+            return;
+
+        case GLFW_RESIZABLE:
+            window->resizable = value;
+            if (!window->monitor)
+                _glfw.platform.setWindowResizable(window, value);
+            return;
+
+        case GLFW_DECORATED:
+            window->decorated = value;
+            if (!window->monitor)
+                _glfw.platform.setWindowDecorated(window, value);
+            return;
+
+        case GLFW_FLOATING:
+            window->floating = value;
+            if (!window->monitor)
+                _glfw.platform.setWindowFloating(window, value);
+            return;
+
+        case GLFW_FOCUS_ON_SHOW:
+            window->focusOnShow = value;
+            return;
+
+        case GLFW_MOUSE_PASSTHROUGH:
+            window->mousePassthrough = value;
+            _glfw.platform.setWindowMousePassthrough(window, value);
+            return;
     }
-    else
+
-        _glfwInputError(GLFW_INVALID_ENUM, "Invalid window attribute 0x%08X", attrib);
+    _glfwInputError(GLFW_INVALID_ENUM, "Invalid window attribute 0x%08X", attrib);
 }
 
 GLFWAPI GLFWmonitor* glfwGetWindowMonitor(GLFWwindow* handle)