From d48ce7da539188d78edbd11742c575df62cf458b Mon Sep 17 00:00:00 2001 From: pbruvoll Date: Fri, 25 Nov 2016 16:00:05 +0100 Subject: [PATCH 1/2] Update sign of all components of scale. Update all components of scale when determinant is negateve,, not just x component --- glm/gtx/matrix_decompose.inl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glm/gtx/matrix_decompose.inl b/glm/gtx/matrix_decompose.inl index 5bf576ac..7194e9d8 100644 --- a/glm/gtx/matrix_decompose.inl +++ b/glm/gtx/matrix_decompose.inl @@ -125,7 +125,7 @@ namespace detail { for(length_t i = 0; i < 3; i++) { - Scale.x *= static_cast(-1); + Scale[i] *= static_cast(-1); Row[i] *= static_cast(-1); } } From 1f8fd8a10681c9fdce75a8a6dbbfabb73d1c71fd Mon Sep 17 00:00:00 2001 From: Christophe Riccio Date: Fri, 25 Nov 2016 21:19:55 +0100 Subject: [PATCH 2/2] Fixed GTX_matrix_decompose decompose #582 --- readme.md | 1 + 1 file changed, 1 insertion(+) diff --git a/readme.md b/readme.md index 35363c52..cfb0b8cd 100644 --- a/readme.md +++ b/readme.md @@ -57,6 +57,7 @@ glm::mat4 camera(float Translate, glm::vec2 const & Rotate) - Fixed POPCNT optimization build in Clang #512 - Fixed intersectRayPlane returns true in parallel case #578 - Fixed GCC 6.2 compiler warnings #580 +- Fixed GTX_matrix_decompose decompose #582 #### [GLM 0.9.8.3](https://github.com/g-truc/glm/releases/tag/0.9.8.3) - 2016-11-12 ##### Improvements: