diff --git a/glm/detail/type_vec4.hpp b/glm/detail/type_vec4.hpp index dcc012eb..dd9756e6 100644 --- a/glm/detail/type_vec4.hpp +++ b/glm/detail/type_vec4.hpp @@ -244,13 +244,13 @@ namespace detail GLM_FUNC_DECL tvec4 & operator= (tvec4 const & v); - GLM_FUNC_DECL tvec4 & operator+=(T s); + GLM_FUNC_DECL tvec4 & operator+=(T v); GLM_FUNC_DECL tvec4 & operator+=(tvec4 const & v); - GLM_FUNC_DECL tvec4 & operator-=(T s); + GLM_FUNC_DECL tvec4 & operator-=(T v); GLM_FUNC_DECL tvec4 & operator-=(tvec4 const & v); - GLM_FUNC_DECL tvec4 & operator*=(T s); + GLM_FUNC_DECL tvec4 & operator*=(T v); GLM_FUNC_DECL tvec4 & operator*=(tvec4 const & v); - GLM_FUNC_DECL tvec4 & operator/=(T s); + GLM_FUNC_DECL tvec4 & operator/=(T v); GLM_FUNC_DECL tvec4 & operator/=(tvec4 const & v); template diff --git a/glm/detail/type_vec4.inl b/glm/detail/type_vec4.inl index 009b8e98..ef631b3a 100644 --- a/glm/detail/type_vec4.inl +++ b/glm/detail/type_vec4.inl @@ -295,12 +295,12 @@ namespace detail #endif template - GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+= (T s) + GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+= (T v) { - this->x += s; - this->y += s; - this->z += s; - this->w += s; + this->x += v; + this->y += v; + this->z += v; + this->w += v; return *this; } @@ -331,12 +331,12 @@ namespace detail } template - GLM_FUNC_QUALIFIER tvec4 & tvec4::operator-= (T s) + GLM_FUNC_QUALIFIER tvec4 & tvec4::operator-= (T v) { - this->x -= s; - this->y -= s; - this->z -= s; - this->w -= s; + this->x -= v; + this->y -= v; + this->z -= v; + this->w -= v; return *this; } @@ -351,12 +351,12 @@ namespace detail } template - GLM_FUNC_QUALIFIER tvec4 & tvec4::operator*= (T s) + GLM_FUNC_QUALIFIER tvec4 & tvec4::operator*= (T v) { - this->x *= s; - this->y *= s; - this->z *= s; - this->w *= s; + this->x *= v; + this->y *= v; + this->z *= v; + this->w *= v; return *this; } @@ -371,12 +371,12 @@ namespace detail } template - GLM_FUNC_QUALIFIER tvec4 & tvec4::operator/= (T s) + GLM_FUNC_QUALIFIER tvec4 & tvec4::operator/= (T v) { - this->x /= s; - this->y /= s; - this->z /= s; - this->w /= s; + this->x /= v; + this->y /= v; + this->z /= v; + this->w /= v; return *this; } @@ -390,9 +390,6 @@ namespace detail return *this; } - - - template template GLM_FUNC_QUALIFIER tvec4 & tvec4::operator= (tvec4 const & v) diff --git a/glm/gtc/quaternion.inl b/glm/gtc/quaternion.inl index a9d5ac52..122cdc42 100644 --- a/glm/gtc/quaternion.inl +++ b/glm/gtc/quaternion.inl @@ -114,9 +114,9 @@ namespace detail detail::tvec3 const & v ) { - detail::tvec3 w = cross(u, v); + detail::tvec3 const LocalW(cross(u, v)); T Dot = detail::compute_dot::call(u, v); - detail::tquat q(T(1) + Dot, w.x, w.y, w.z); + detail::tquat q(T(1) + Dot, LocalW.x, LocalW.y, LocalW.z); *this = normalize(q); }